Refactor badge generation code

validata_core/__init__.py

@@ -242,6 +242,18 @@ class Validator:
 def compute_badge(report, config) -> dict:
     """Compute badge from report statistics and badge configuration."""
 
+    def build_badge(structure_status, body_status=None, error_ratio=None):
+        """Badge info creation"""
+        if structure_status == 'KO':
+            return {
+                "structure": 'KO'
+            }
+        return {
+            "structure": structure_status,
+            "body": body_status,
+            "error-ratio": error_ratio
+        }
+
     # Gets stats from report
     stats = report['tables'][0]['error-stats']
 
@@ -252,11 +264,7 @@ def compute_badge(report, config) -> dict:
 
     # No errors
     if stats['count'] == 0:
-        return {
-            "structure": 'OK',
-            "body": 'OK',
-            "error-ratio": 0.0,
-        }
+        return build_badge('OK', 'OK', 0.0)
 
     # Structure part
     structure_status = None
@@ -268,18 +276,12 @@ def compute_badge(report, config) -> dict:
             structure_status = 'WARN'
         else:
             # structure_status = 'KO'
-            return {
-                "structure": 'KO'
-            }
+            return build_badge('KO')
 
     # body part
     value_errors = stats['value-errors']
     if value_errors['count'] == 0:
-        return {
-            "structure": structure_status,
-            "body": 'OK',
-            "error-ratio": 0.0
-        }
+        return build_badge(structure_status, 'OK', 0.0)
 
     # Computes error ratio
     weight_dict = config['body']['errors-weight']
@@ -287,8 +289,4 @@ def compute_badge(report, config) -> dict:
         / cell_total_number
     body_status = 'WARN' if ratio < config['body']['acceptability-threshold'] else 'KO'
 
-    return {
-        "structure": structure_status,
-        "body": body_status,
-        "error-ratio": ratio
-    }
+    return build_badge(structure_status, body_status, ratio)