Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • V Validata Core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 11
    • Issues 11
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Validata
  • Validata Core
  • Merge requests
  • !10

Pass options to Inspector's init

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Antoine Augusti requested to merge AntoineAugusti/validata-core:inspector-init-options into master Apr 24, 2020
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Relates to #11 (closed)

This is a possible implementation. The issue arises because options are accepted:

  • at the init level of the Inspector
  • at the inspect level of the Inspector

Currently, options are only passed to the inspect method of the Inspector, making it impossible to override things like the maximum number of errors (limit is fixed at 1000 by goodtables).

This implementation uses a single options dict and extracts the relevant keys to be passed to the init method.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: inspector-init-options

OpenDataFrance.net